Skip to content

HDFS-15518. Fixed String operationName = ListSnapshot.#2217

Merged
hemanthboyina merged 2 commits intoapache:trunkfrom
aryangupta1998:HDFS-15518
Aug 12, 2020
Merged

HDFS-15518. Fixed String operationName = ListSnapshot.#2217
hemanthboyina merged 2 commits intoapache:trunkfrom
aryangupta1998:HDFS-15518

Conversation

@aryangupta1998
Copy link
Contributor

@aryangupta1998 aryangupta1998 commented Aug 11, 2020

Fixed String operationName = ListSnapshot.

Link: https://issues.apache.org/jira/browse/HDFS-15518

@hemanthboyina
Copy link
Contributor

hemanthboyina commented Aug 11, 2020

the operation name can be common for audit log and lock

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 11, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 28m 59s trunk passed
+1 💚 compile 1m 15s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 1m 12s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 0m 53s trunk passed
+1 💚 mvnsite 1m 17s trunk passed
+1 💚 shadedclient 15m 59s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 50s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 30s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 2m 59s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 2m 57s hadoop-hdfs-project/hadoop-hdfs in trunk has 2 extant findbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 7s the patch passed
+1 💚 compile 1m 5s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 1m 5s the patch passed
+1 💚 compile 1m 4s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 1m 4s the patch passed
+1 💚 checkstyle 0m 42s the patch passed
+1 💚 mvnsite 1m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 41s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 45s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 20s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 3m 2s the patch passed
_ Other Tests _
-1 ❌ unit 116m 10s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
198m 1s
Reason Tests
Failed junit tests hadoop.hdfs.TestFileChecksum
hadoop.hdfs.TestAclsEndToEnd
hadoop.hdfs.TestDFSClientRetries
hadoop.hdfs.server.datanode.TestDataNodeLifeline
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.TestReplication
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.TestDFSStripedOutputStream
hadoop.hdfs.TestMiniDFSCluster
hadoop.hdfs.TestReconstructStripedFile
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/1/artifact/out/Dockerfile
GITHUB PR #2217
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c14640de2ba4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6c2ce3d
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
findbugs https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/1/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/1/testReport/
Max. process+thread count 4139 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bshashikant
bshashikant previously approved these changes Aug 12, 2020
View reviewed changes
bshashikant
bshashikant reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@bshashikant bshashikant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the operation name common for lock as well as the audit logs.

@bshashikant bshashikant dismissed their stale review August 12, 2020 10:40

need changes

@hemanthboyina
Copy link
Contributor

hemanthboyina commented Aug 12, 2020

+1 , will wait for jenkins

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 12, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 4s trunk passed
+1 💚 compile 1m 18s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 1m 10s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 0m 49s trunk passed
+1 💚 mvnsite 1m 16s trunk passed
+1 💚 shadedclient 17m 44s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 49s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 18s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 6s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 4s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 9s the patch passed
+1 💚 compile 1m 11s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 1m 11s the patch passed
+1 💚 compile 1m 5s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 1m 5s the patch passed
+1 💚 checkstyle 0m 44s the patch passed
+1 💚 mvnsite 1m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 24s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 45s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 16s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 3m 11s the patch passed
_ Other Tests _
-1 ❌ unit 109m 42s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
197m 37s
Reason Tests
Failed junit tests hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.TestRollingUpgrade
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/2/artifact/out/Dockerfile
GITHUB PR #2217
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f4a1b7309050 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1071604
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/2/testReport/
Max. process+thread count 2883 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2217/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hemanthboyina
Copy link
Contributor

hemanthboyina commented Aug 12, 2020

+1

@hemanthboyina hemanthboyina merged commit e592ec5 into apache:trunk Aug 12, 2020
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@aryangupta1998 @mukul1987
HDFS-15518. Wrong operation name in FsNamesystem for listSnapshots. (a…
667e4bc 
…pache#2217)

* HDFS-15518. Fixed String operationName = ListSnapshot.

* HDFS-15518. Changed ListSnapshot to operationName.

Co-authored-by: Aryan Gupta <aryan.gupta@cloudera.com>
(cherry picked from commit e592ec5)
Change-Id: I79561a349b7286d2390529812dd7079aee31f7b2
(cherry picked from commit 53da829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshashikant bshashikant bshashikant left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aryangupta1998 @hemanthboyina @hadoop-yetus @bshashikant